fix: ensure plugin version is updated in action.yml #1257
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@LogFlames please review this small PR. Once you merge, I suggest that you make a patch release because |
algomaster99
changed the title
|
Thanks for the PR! Unfortunately I haven't gotten SNAPSHOT releases to work yet, so this would cause CI to fail as the latest SNAPSHOT version of maven-lockfile is not available on maven central. I'm also thinking that it might be preferable for the project to use the latest full release of the project:
|
I agree with this.
Yes, if you can have a script to get the version from POM and then trigger this script only on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
$PLUGIN_VERSIONis pinned to5.5.2. It was accidentally introduced in https://github.com/chains-project/maven-lockfile/pull/1211/files#diff-e23072be6fce0672ff37f9bae970d4df7189edd43bccee7223ae0b0c25b090f5R95. These changes ensure thataction.ymlis updated accordingly with each release.